[BUG] Vite Server Crashing Chrome #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed circular dependencies and isolated key structures into separate files. Cleanup still needed.
HunterBarclay
requested review from
a-crowell and
LucaHaverty
and removed request for
a team
BrandonPacewic
approved these changes
Sep 4, 2024
PepperLola
approved these changes
Sep 4, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Vite server has been crashing Google Chrome since the introduction of the new configuration panel. It appears that the configuration files had a number of circular dependencies that either couldn't be resolved by Google Chrome's debugger or ran into a vulnerability it Google Chrome's debugger that causes a crash.
Solution
I move a handful of share objects between the configuration panel and it's interfaces into separate classes to remedy the circular dependencies
Other Notes
I intentionally created circular dependencies to test my theory that simply circular dependencies were the issue, but they were resolved without issue. This makes me believe that either the mildly cursed work arounds we are using in React or the specific complexity of the circular dependencies were what caused the crash. Other than that, I'm not entirely sure what caused the crash or how we can directly avoid going forward, other than the obviously of having no circular dependencies.
JIRA Issue - 1859